Added comments to output. by borut-t · Pull Request #84 · netbe/Babelish

borut-t · 2016-01-12T11:26:55Z

No description provided.

houndci-bot · 2016-01-12T11:26:56Z

lib/babelish/csv2android.rb

Use 2 (not 4) spaces for indentation.

netbe · 2016-01-12T11:36:54Z

@borut-t thanks! could you add a unit test to it?

houndci-bot · 2016-01-12T11:50:34Z

test/babelish/test_csv2android.rb

Trailing whitespace detected.

houndci-bot · 2016-01-12T11:56:23Z

test/babelish/test_csv2android.rb

Align the parameters of a method call if they span more than one line.
Space inside { missing.
Space inside } missing.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2016-01-12T12:22:35Z

test/babelish/test_csv2android.rb

Align the parameters of a method call if they span more than one line.

borut-t · 2016-01-12T12:25:58Z

@netbe Ok. I've made tests. When can I expect this to be released?

netbe · 2016-01-12T14:51:50Z

@borut-t I'll try this week, I need to fix #79 for the release, two more things:

Could you fix the style issues by @houndci ?
Would be great if you add support for comments from android to csv (this could be a second PR) :)

Thanks again for your contribution I

borut-t · 2016-01-29T09:11:37Z

@netbe Are there any guidelines about formatting cos I could not get this:

Align the parameters of a method call if they span more than one line.
Space inside { missing.
Space inside } missing.

houndci-bot · 2016-01-29T13:11:36Z

test/babelish/test_csv2android.rb

Tab detected.
Trailing whitespace detected.

houndci-bot · 2016-01-29T13:14:19Z

test/babelish/test_csv2android.rb

Align the parameters of a method call if they span more than one line.
Tab detected.

houndci-bot · 2016-01-29T13:19:35Z

test/babelish/test_csv2android.rb

Align the parameters of a method call if they span more than one line.

houndci-bot · 2016-01-29T13:24:09Z

test/babelish/test_csv2android.rb

Align the parameters of a method call if they span more than one line.

houndci-bot · 2016-01-29T13:25:56Z

test/babelish/test_csv2android.rb

Align the parameters of a method call if they span more than one line.
Tab detected.

houndci-bot · 2016-01-29T13:30:08Z

test/babelish/test_csv2android.rb

unexpected token tCOMMA
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

houndci-bot · 2016-01-29T13:32:16Z

test/babelish/test_csv2android.rb

unexpected token tCOMMA
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

houndci-bot · 2016-01-29T13:34:03Z

test/babelish/test_csv2android.rb

unexpected token tCOMMA
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

borut-t · 2016-01-29T13:45:56Z

@netbe Finally was able to clean all style issue. Could we proceed?

Added comments to output.

netbe · 2016-01-29T15:16:36Z

yes great thks!

coveralls · 2018-01-11T16:01:46Z

Coverage decreased (-53.8%) to 34.405% when pulling 70521d2 on borut-t:master into 6830aa9 on netbe:master.

borut-t added 2 commits January 12, 2016 12:25

Added comments to output.

5f68962

Added comments to output.

a9e06ef

houndci-bot reviewed Jan 12, 2016
View reviewed changes

lib/babelish/csv2android.rb Outdated

Copy link

Collaborator

houndci-bot Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 4) spaces for indentation.

Fixed typo.

19c4cd0

borut-t mentioned this pull request Jan 12, 2016

Comments support on android #83

Closed

Added csv2android with comments test case.

7ae98bb

houndci-bot reviewed Jan 12, 2016
View reviewed changes

test/babelish/test_csv2android.rb Outdated

Copy link

Collaborator

houndci-bot Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

Fixed typos.

0cf5dab

houndci-bot reviewed Jan 12, 2016
View reviewed changes

borut-t added 5 commits January 12, 2016 13:03

Fixed new lines indentation.

2a87a91

Fixed indentation issue.

feab4b1

Fixed style.

d8757eb

Fixed typos.

f857e06

Replaced single with double quotes.

f1375ab

houndci-bot reviewed Jan 12, 2016
View reviewed changes

test/babelish/test_csv2android.rb Outdated

Copy link

Collaborator

houndci-bot Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

borut-t added 2 commits January 29, 2016 14:04

Fixed style issue.

2528ec9

Fixed style issue.

1a1498e

houndci-bot reviewed Jan 29, 2016
View reviewed changes

test/babelish/test_csv2android.rb Outdated

Copy link

Collaborator

houndci-bot Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab detected.
Trailing whitespace detected.

houndci-bot reviewed Jan 29, 2016
View reviewed changes

borut-t added 2 commits January 29, 2016 14:15

Fixed style issue.

8879cab

Fixed style issue.

4d3b1b1

houndci-bot reviewed Jan 29, 2016
View reviewed changes

test/babelish/test_csv2android.rb Outdated

Copy link

Collaborator

houndci-bot Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

Fixed style issue.

a8f31cf

houndci-bot reviewed Jan 29, 2016
View reviewed changes

test/babelish/test_csv2android.rb Outdated

Copy link

Collaborator

houndci-bot Jan 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the parameters of a method call if they span more than one line.

Fixed style issue.

03f6b13

houndci-bot reviewed Jan 29, 2016
View reviewed changes

borut-t added 2 commits January 29, 2016 14:27

Fixed style issue.

274836b

Fixed style issue.

77cc37f

houndci-bot reviewed Jan 29, 2016
View reviewed changes

Fixed style issue.

308b39a

houndci-bot reviewed Jan 29, 2016
View reviewed changes

Fixed style issue.

a88fd62

houndci-bot reviewed Jan 29, 2016
View reviewed changes

borut-t added 3 commits January 29, 2016 14:36

Fixed style issue.

70521d2

Fixed style issue.

b084e0f

Fixed style issue.

3c779a6

netbe added a commit that referenced this pull request Jan 29, 2016

Merge pull request #84 from borut-t/master

6a58262

Added comments to output.

netbe merged commit 6a58262 into netbe:master Jan 29, 2016

Conversation

borut-t commented Jan 12, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

netbe commented Jan 12, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

borut-t commented Jan 12, 2016

Uh oh!

netbe commented Jan 12, 2016

Uh oh!

borut-t commented Jan 29, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

borut-t commented Jan 29, 2016

Uh oh!

netbe commented Jan 29, 2016

Uh oh!

coveralls commented Jan 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Jan 11, 2018 •

edited

Loading